wp 3.7

Discussion:

wp 3.7

Luke Bryan

2013-10-25 16:20:11 UTC

Greetings all,

3.7 is nice, but I was noticing an intermittent problem, happening even on
make.wordpress.org blog. (https://make.wordpress.org/core/wp-login.php) The
first login attempt says you don't have cookies enabled - second login
works fine though. (I'm using Firefox).

I was also wondering what happened to the search-relevance functionality,
since it isn't mentioned here (http://wordpress.org/news/2013/10/basie/) -
was this feature dropped for 3.7?

Best regards,
Luke

Nikola Nikolov

2013-10-25 19:05:12 UTC

Permalink

Hi Luke,

I couldn't replicate the issue on the make.wordpress site - I tried with
both normal and incognito views and I didn't get any messages about
cookies(just the normal login form).

About the search-relevance - as far as I read in the updated page(when the
update to 3.7 finishes and you see the big nice screen with all the good
stuff in 3.7) it is there and should be working.

Nikola

Post by Luke Bryan
Greetings all,
3.7 is nice, but I was noticing an intermittent problem, happening even on
make.wordpress.org blog. (https://make.wordpress.org/core/wp-login.php) The
first login attempt says you don't have cookies enabled - second login
works fine though. (I'm using Firefox).
I was also wondering what happened to the search-relevance functionality,
since it isn't mentioned here (http://wordpress.org/news/2013/10/basie/) -
was this feature dropped for 3.7?
Best regards,
Luke
_______________________________________________
wp-hackers mailing list
http://lists.automattic.com/mailman/listinfo/wp-hackers

Luke Bryan

2013-10-25 21:02:57 UTC

Permalink

Here are the steps to reproduce the problem:

Go to https://make.wordpress.org/core/wp-login.php, click on the icon by
the url and go to more information.

View cookies, remove all cookies.

Now when you log in it will first give you the message "*ERROR*: Cookies
are blocked or not supported by your browser. You must enable
cookies<http://www.google.com/cookies.html>to use WordPress."

Should happen in Firefox 24,25, but I tested in Chrome and it didn't give
the message. Maybe a bug in either Firefox or Chrome's cookie setup?

Thanks
Luke

------------------------------

Hi Luke,

I couldn't replicate the issue on the make.wordpress site - I tried with
both normal and incognito views and I didn't get any messages about
cookies(just the normal login form).

About the search-relevance - as far as I read in the updated page(when the
update to 3.7 finishes and you see the big nice screen with all the good
stuff in 3.7) it is there and should be working.

Nikola

On Fri, Oct 25, 2013 at 7:20 PM, Luke Bryan <lukebryan at

* Greetings all,*>**>* 3.7 is nice, but I was noticing an intermittent problem, happening even on*>* make.wordpress.org blog. (https://make.wordpress.org/core/wp-login.php)*>* The*>* first login attempt says you don't have cookies enabled - second login*>* works fine though. (I'm using Firefox).*>**>* I was also wondering what happened to the search-relevance functionality,*>* since it isn't mentioned here (http://wordpress.org/news/2013/10/basie/) -*>* was this feature dropped for 3.7?*>**>* Best regards,*>* Luke*>* _______________________________________________*>* wp-hackers mailing list*>* wp-hackers at lists.automattic.com <http://lists.automattic.com/mailman/listinfo/wp-hackers>*>* http://lists.automattic.com/mailman/listinfo/wp-hackers*>**

Nikola Nikolov

2013-10-25 21:05:10 UTC

Permalink

Hmmm... Can you try to replicate this in a 3.6 install with Firefox?

Post by Luke Bryan
Go to https://make.wordpress.org/core/wp-login.php, click on the icon by
the url and go to more information.
View cookies, remove all cookies.
Now when you log in it will first give you the message "*ERROR*: Cookies
are blocked or not supported by your browser. You must enable
cookies<http://www.google.com/cookies.html>to use WordPress."
Should happen in Firefox 24,25, but I tested in Chrome and it didn't give
the message. Maybe a bug in either Firefox or Chrome's cookie setup?
Thanks
Luke
------------------------------
Hi Luke,
I couldn't replicate the issue on the make.wordpress site - I tried with
both normal and incognito views and I didn't get any messages about
cookies(just the normal login form).
About the search-relevance - as far as I read in the updated page(when the
update to 3.7 finishes and you see the big nice screen with all the good
stuff in 3.7) it is there and should be working.
Nikola
On Fri, Oct 25, 2013 at 7:20 PM, Luke Bryan <lukebryan at
sharefaith.com <http://lists.automattic.com/mailman/listinfo/wp-hackers

* Greetings all,*>**>* 3.7 is nice, but I was noticing an intermittent

problem, happening even on*>* make.wordpress.org blog. (
https://make.wordpress.org/core/wp-login.php)*>* The*>* first login
attempt says you don't have cookies enabled - second login*>* works fine
though. (I'm using Firefox).*>**>* I was also wondering what happened to
the search-relevance functionality,*>* since it isn't mentioned here (
http://wordpress.org/news/2013/10/basie/) -*>* was this feature dropped
for 3.7?*>**>* Best regards,*>* Luke*>*
_______________________________________________*>* wp-hackers mailing
list*>* wp-hackers at lists.automattic.com <
http://lists.automattic.com/mailman/listinfo/wp-hackers>*>*
http://lists.automattic.com/mailman/listinfo/wp-hackers*>**
_______________________________________________
wp-hackers mailing list
http://lists.automattic.com/mailman/listinfo/wp-hackers

Chris Jean

2013-10-25 21:14:25 UTC

Permalink

It's due to this line that was added to wp-login.php in 3.7:

if ( isset($_POST['testcookie']) && empty($_COOKIE[TEST_COOKIE]) )

This didn't exist before.

Since the cookie is set on page load, triggering this issue would seem
to require clearing cookies just before logging in, having cookies
disabled until already on the page, or some other type of process on the
browser that is blocking cookies.

Luke, do you have anything on your browser that blocks, disables, or
otherwise modifies cookies?

Chris Jean (AKA gaarai & chrisbliss18)
Coder for ithemes.com
chrisjean.com
@chrisjean

Post by Nikola Nikolov
Hmmm... Can you try to replicate this in a 3.6 install with Firefox?

* Greetings all,*>**>* 3.7 is nice, but I was noticing an intermittent

_______________________________________________
wp-hackers mailing list
http://lists.automattic.com/mailman/listinfo/wp-hackers

Otto

2013-10-25 21:41:51 UTC

Permalink

That's actually intentional. The test cookie is set on the load of the
wp-login.php screen. When you log in, it checks for the existence of
that test cookie and won't log you in without it.

This is to give better feedback than before, for login attempts where
cookies were disabled, but the username and password given was
correct. See http://core.trac.wordpress.org/ticket/24961 .

Now, obviously, if you clear the cookies between loading the login
page and logging in, then you're going to have problems, because it's
testing for the existence of the cookie it just set on the login
screen.

-Otto